Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 6 of 6
  1. #1
    New Coder
    Join Date
    Jan 2005
    Posts
    85
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Would appreciate some critique and advice

    Hi all,

    http://www.kdok.com/

    I just finished a redesign of this site for one of our stations.

    Some of the issues I tried to address are:

    scalabilty (text resizing - I'm using ems now instead of fixed [pixels])
    semantics (better use of...)
    separation of style and content
    elimination of bulky JS for menus (all suckerfish and lists now)

    I think I did a pretty good job of each but, of course, I'm sure there is some room for improvement.

    I'm not crazy about white text on a dark background but I was over-ruled on that one so I tried to make it as readable as I could.

    It all validates as xhtml 1.0 Trans (except the news.php page - grrrr)

    I would appreciate any comments or suggestions altho I'm already cringing.

    Thanks
    Dodge
    Last edited by Dodge; 10-17-2005 at 06:26 PM.

  • #2
    Regular Coder Lerura's Avatar
    Join Date
    Aug 2005
    Location
    Denmark
    Posts
    947
    Thanks
    0
    Thanked 130 Times in 129 Posts
    about the white text:

    you could try to make the text a little darker in the same hue as the bgcolor
    in your case i will suggest "#F5F5FF". Then it will still look white but will have a lesser blured/shivering effect and thus making it more readable

  • #3
    Rockstar Coder
    Join Date
    Jun 2002
    Location
    USA
    Posts
    9,074
    Thanks
    1
    Thanked 328 Times in 324 Posts
    Why are you setting all your ULs and LIs to the class 'topmenu' that isn't needed.

    Just define the properties for your ULs based off the nav list.

    e.g.

    Code:
    #nav ul
    {
    
    ... stuff here will automatically get applied to ULs inside the nav element
    }
    Also changing the text alignment from left to right on hover in the menu is really annoying and makes it harder to use.
    OracleGuy

  • #4
    New Coder
    Join Date
    Jan 2005
    Posts
    85
    Thanks
    0
    Thanked 0 Times in 0 Posts
    lerura - thanks! That is such a subtle change but it's very effective - I like it.

    oracleguy - thank you for the tip on ".topmenu" - I did apparently go overboard on specifying that class when it wasn't necessary at all - I have since change it as you directed - using #nav.

    I like the align: right on the hover ... but I know that little things like that can be annoying to some. I've changed it to align: center to cut the movement a bit - I may end of changing it to align to the left in the end.

    Thanks
    Dodge

  • #5
    New Coder
    Join Date
    Jan 2005
    Posts
    85
    Thanks
    0
    Thanked 0 Times in 0 Posts
    hmmm... did I mention that I would really appreciate it... comments and advice I mean?

    Thanks for the 2 so far for sure - but either the site really, really sucks bad or it's just not worth anyone's time to just get to comments?? If that be the case I need to get back to the old drawing board I guess. :\

    Dodge

  • #6
    Rockstar Coder
    Join Date
    Jun 2002
    Location
    USA
    Posts
    9,074
    Thanks
    1
    Thanked 328 Times in 324 Posts
    Just give it a little more time and more people will come by and have a peek.
    OracleGuy


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •