Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Page 1 of 2 12 LastLast
Results 1 to 15 of 25
  1. #1
    New Coder
    Join Date
    Jun 2008
    Location
    Belgrade
    Posts
    19
    Thanks
    17
    Thanked 0 Times in 0 Posts

    Smile Please Review my First PHP Site

    Hi there

    www.eynsoft.com is my first PHP site ,really refreshing after ASP
    Anyway tell me what you think

    Regards,

    Marko Jovanovic

  • #2
    Banned
    Join Date
    Jun 2008
    Location
    Kiev, Ukraine
    Posts
    72
    Thanks
    8
    Thanked 4 Times in 4 Posts
    Design:
    I love it. The effects are all nice, as well as the navigation.
    The colours are pleasing to they eye, however, I would opt for a colour like #BAF100 on the top header bg. (Its a yellow green)
    Also, I would make the logo come down a tad. Its at the corner of my screen.

    Technical:
    :O VALIDATION!!! NEARLLY 300 ERRORS! http://validator.w3.org/check?uri=ht...Inline&group=0

    Maybe make the navigation an accordian, saving load time.

  • Users who have thanked Vijo for this post:

    okram666 (06-25-2008)

  • #3
    Senior Coder gnomeontherun's Avatar
    Join Date
    Sep 2007
    Location
    Houston
    Posts
    2,846
    Thanks
    10
    Thanked 238 Times in 229 Posts
    Likes:
    The overall design is pretty nice, clean, and doesn't try to do too much at once.
    The site structure is logical, makes sense and easy to navigate.

    Improvements:
    I can't read your logo, the contrast is really poor for the white text and lime bar.
    I would keep your logo and search bar in the center as well, on my widescreen it expands so far out that it looks awkward.
    The roll overs for your menu make the item harder to read when you roll over.
    The forum login seems a little out of place on all of the pages.
    When you are looking at a subdirectory of the site, it would be nice to have something to help visually remind you where you are, some kind of Section Title or image.
    jeremy - gnomeontherun
    Educated questions often get educated answers, and simple questions often get simple answers.

  • Users who have thanked gnomeontherun for this post:

    okram666 (06-25-2008)

  • #4
    New Coder
    Join Date
    Jun 2008
    Location
    Belgrade
    Posts
    19
    Thanks
    17
    Thanked 0 Times in 0 Posts
    Quote Originally Posted by Vijo View Post
    Design:
    I love it. The effects are all nice, as well as the navigation.
    The colours are pleasing to they eye, however, I would opt for a colour like #BAF100 on the top header bg. (Its a yellow green)
    Also, I would make the logo come down a tad. Its at the corner of my screen.
    My favorite color is green
    Actually i was considering to change color of the header, probably in something like #BAF100... Thaks for that "color code"
    Quote Originally Posted by Vijo View Post
    Technical:
    :O VALIDATION!!! NEARLLY 300 ERRORS! http://validator.w3.org/check?uri=ht...Inline&group=0

    Maybe make the navigation an accordian, saving load time.
    Yea I know but to be honest i don't understand why is that so important? Sites like soft32 or softpedia and many others, have a lot more errors...

    Thanks for review

    Quote Originally Posted by jeremywilken View Post
    Likes:
    The overall design is pretty nice, clean, and doesn't try to do too much at once.
    The site structure is logical, makes sense and easy to navigate.

    Improvements:
    I can't read your logo, the contrast is really poor for the white text and lime bar.
    I would keep your logo and search bar in the center as well, on my widescreen it expands so far out that it looks awkward.
    The roll overs for your menu make the item harder to read when you roll over.
    The forum login seems a little out of place on all of the pages.
    I will fix that...

    Quote Originally Posted by jeremywilken View Post
    When you are looking at a subdirectory of the site, it would be nice to have something to help visually remind you where you are, some kind of Section Title or image.
    Great idea I will add something like that, or maybe change colors...


    P.S. Thanks again to both of you

  • #5
    Regular Coder
    Join Date
    May 2008
    Location
    Lost in Localhost...
    Posts
    702
    Thanks
    3
    Thanked 43 Times in 42 Posts
    Good:
    Web design is beautiful, seriously, very nice.
    (Everything on the site works fine) and the graphics look great.
    Stuff stands out that you want to see, and it's all structured nicely in correct order. (Apart from the top-right navigation)

    Dislike:
    The menu at the top right is very small, maybe make it stand out or bigger. If people can't find the site navigation, then your site just won't work.
    VALIDATE VALIDATE VALIDATE! Fix your validation errors!

    Privacy Policy | Contact | Help | Terms of use | Copyright ©2007 EynSoft.com. All rights reserved
    They aren't hyper-linked. They don't lead anywhere!

    My thoughts.
    Last edited by Millenia; 06-25-2008 at 06:56 PM.

  • Users who have thanked Millenia for this post:

    okram666 (06-25-2008)

  • #6
    Regular Coder
    Join Date
    May 2008
    Location
    Lost in Localhost...
    Posts
    702
    Thanks
    3
    Thanked 43 Times in 42 Posts
    I found this error:

    Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/eynsof5/public_html/linuxcat.php on line 328

    Here


    You might want to check the other links in this case.

    Edit:

    The design goes wrong on this page, the navigation screws up.
    (If it's meant to look like that, then I apologise, it looks like it has gone wrong )

    I think your best going through every link and checking them all. I'm guessing there's much more erorrs like these.

    Second Edit:

    And another MySQL error here:

    Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/eynsof5/public_html/maccat.php on line 322
    Here

    I'll leave it for you to find more.

    Third Edit:

    Under the green at the top, and above the box of content, there is an invisible link to the Mobile section of the website. Kinda wierd

    (Sorry for finding errors in your site, it's better PHP that I could have done)
    Last edited by Millenia; 06-25-2008 at 06:54 PM.

  • Users who have thanked Millenia for this post:

    okram666 (06-25-2008)

  • #7
    Regular Coder
    Join Date
    Sep 2007
    Location
    AZ, USA
    Posts
    685
    Thanks
    6
    Thanked 46 Times in 46 Posts
    Design:
    + Nice soft design, coherent color scheme, graphics fit the site
    + I love the glow/reflection effect on the rollovers of Windows, Mac, and Linux
    + Great page structure
    - Perhaps the text size could be a bit bigger?

    Technical:
    - At the bottom the Privacy Policy, Contact, etc aren't linked.
    - Doesn't validate
    - Tables for layout a bit (bad coding practice)
    - On the contact form there is no validation; it allows you to send a blank, empty email
    - I pressed the search button without putting anything in the search box and it gave me:
    Showing page 1 of 0 pages
    It was actually not showing any pages.

    Nice looking site, a great one for your first!

    Yea I know but to be honest i don't understand why is that so important? Sites like soft32 or softpedia and many others, have a lot more errors...
    A site can, and obviously many do, work without valid code. But having code that complies to standards helps all browsers understand it better (with the possible exception of IE ). It could increase the loading speeds just because the browser will be able to instantly understand it, instead of having to figure out how to cope with the error.

  • Users who have thanked binaryWeapon for this post:

    okram666 (06-25-2008)

  • #8
    New Coder
    Join Date
    Jun 2008
    Location
    Belgrade
    Posts
    19
    Thanks
    17
    Thanked 0 Times in 0 Posts
    Quote Originally Posted by Millenia View Post
    ...
    Under the green at the top, and above the box of content, there is an invisible link to the Mobile section of the website. Kinda wierd
    (Sorry for finding errors in your site, it's better PHP that I could have done)
    I'm aware of that MySQL errors... I it's happening when empty mysql_query record is passed to another mysql_query but i will fix that

    On the pages with subcategories navigation is wierd because of height of div (when is empty) i will fix that too

    Quote Originally Posted by Millenia View Post
    Third Edit:

    Under the green at the top, and above the box of content, there is an invisible link to the Mobile section of the website. Kinda wierd
    Ouh thats a problem... You probally have 1024x768 resolution.... I just found out that mobile link is move down on that res...


    Thank you very much for feedback

    Quote Originally Posted by binaryWeapon View Post
    Design:
    + Nice soft design, coherent color scheme, graphics fit the site
    + I love the glow/reflection effect on the rollovers of Windows, Mac, and Linux
    + Great page structure
    - Perhaps the text size could be a bit bigger?

    Technical:
    - At the bottom the Privacy Policy, Contact, etc aren't linked.
    - Doesn't validate
    - Tables for layout a bit (bad coding practice)
    - On the contact form there is no validation; it allows you to send a blank, empty email
    - I pressed the search button without putting anything in the search box and it gave me: It was actually not showing any pages.

    Nice looking site, a great one for your first!
    Thanks for reply...

    Yes i know about footer... I need to write terms of use, privacy police and other but I don't know english so well for that

    Quote Originally Posted by binaryWeapon View Post
    A site can, and obviously many do, work without valid code. But having code that complies to standards helps all browsers understand it better (with the possible exception of IE ). It could increase the loading speeds just because the browser will be able to instantly understand it, instead of having to figure out how to cope with the error.
    Thank you... Finally some real answer for that question... until now everybody was saying:"Thats standard you must do like that, but why I don't have idea"
    Last edited by okram666; 06-25-2008 at 07:40 PM.

  • #9
    Regular Coder
    Join Date
    May 2008
    Location
    Lost in Localhost...
    Posts
    702
    Thanks
    3
    Thanked 43 Times in 42 Posts
    Yes i know about footer... I need to write terms of use, privacy police and other but I don't know english so well for that
    This sounds a bit cheating, but maybe you could go onto any website, copy their privacy policy and copyright stuff and modify it? To save you from writing your own.

  • #10
    New Coder
    Join Date
    Jun 2008
    Location
    Belgrade
    Posts
    19
    Thanks
    17
    Thanked 0 Times in 0 Posts
    Quote Originally Posted by Millenia View Post
    This sounds a bit cheating, but maybe you could go onto any website, copy their privacy policy and copyright stuff and modify it? To save you from writing your own.
    I was planning to do something like that

  • #11
    Master Coder
    Join Date
    Dec 2007
    Posts
    6,682
    Thanks
    436
    Thanked 890 Times in 879 Posts
    Quote Originally Posted by Millenia View Post
    This sounds a bit cheating, but maybe you could go onto any website, copy their privacy policy and copyright stuff and modify it? To save you from writing your own.
    Quote Originally Posted by okram666 View Post
    I was planning to do something like that
    do you think that this is legal?

    regards

  • #12
    Regular Coder
    Join Date
    Sep 2007
    Location
    AZ, USA
    Posts
    685
    Thanks
    6
    Thanked 46 Times in 46 Posts
    I believe there are privacy policy generators.

    http://www.dmaresponsibility.org/PPG/
    http://www.google.com/search?hl=en&q...=Google+Search

    Never seen something like that for T&Cs though.

  • Users who have thanked binaryWeapon for this post:

    okram666 (06-25-2008)

  • #13
    Senior Coder gnomeontherun's Avatar
    Join Date
    Sep 2007
    Location
    Houston
    Posts
    2,846
    Thanks
    10
    Thanked 238 Times in 229 Posts
    Legal language doesn't change much as long as you find a site with a similar purpose. The problem is they may have paid a lawyer for that text...

    Since you are providing software which is going to change a users computer, it is best to make sure to be very clear that you provide this without any warranty, no guarantees, etc. I wonder if you shouldn't even have some terms of use box that people have to check before they download software?
    jeremy - gnomeontherun
    Educated questions often get educated answers, and simple questions often get simple answers.

  • Users who have thanked gnomeontherun for this post:

    okram666 (06-25-2008)

  • #14
    The Apostate Apostropartheid's Avatar
    Join Date
    Oct 2007
    Posts
    3,215
    Thanks
    16
    Thanked 265 Times in 263 Posts
    It strikes me as very overwhelming. I can't really understand where my eyes should go first, because your heads don't stand out very well and are completely tossed out by their colored subheads. This lack of structure is...confusing.

    Although I like the design, there are a few things which look a bit off. The section links on your head look like they were supposed to be centered over the middle part of the gradient and the logo is hard to read.

    Also your text is unforgivably small. Try making it more readable or change it to a more legible font at small sizes (I've played about with it and Verdana at 11 pixels with a 1.5 leading looks clean and lovely.)

    It's going along well though, keep it up!

  • Users who have thanked Apostropartheid for this post:

    okram666 (06-25-2008)

  • #15
    Banned
    Join Date
    Jun 2008
    Location
    Kiev, Ukraine
    Posts
    72
    Thanks
    8
    Thanked 4 Times in 4 Posts
    I agree with CyanLight. I did have to strain my eyes to get to see it. Not very good on accessibility.

    Also, why not have a header that changes colour? Like from Green, to orange, to blue etc.. =]


  •  
    Page 1 of 2 12 LastLast

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •