Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Page 1 of 2 12 LastLast
Results 1 to 15 of 27

Thread: Site Review

  1. #1
    Regular Coder GSimpson's Avatar
    Join Date
    Aug 2006
    Location
    New Zealand
    Posts
    268
    Thanks
    9
    Thanked 0 Times in 0 Posts

    Site Review

    Hey Guys,
    Just created a website for someone, just went through and made the main layout and shop layout but haven't done any spectacular in the way of coding. If you can spot something that isn't looking right, no working, could you please let me know.

    http://gingaart.freehostia.com/layout 1/

    Thanks, Glyn.

  • #2
    Senior Coder ahallicks's Avatar
    Join Date
    May 2006
    Location
    Lancaster, UK
    Posts
    1,134
    Thanks
    1
    Thanked 57 Times in 55 Posts
    Couple of things:

    - There is no alt or title attribute for the HTML tag! I've never seen it used and it's definitely not valid. You should be putting that sort of stuff in the meta tags.

    - Also there is a div missing, you have not closed the 'master' div after the footer.

    - And I think you need to preload the buttons because I got some big blank gaps when I rolled over first time!

    Other than that the site is nice and clean, although lacking in information as of yet, but I'm sure that's something that you're working on once the design is sorted. One thing I would say is for accessibility reasons I would have some kind of alternative to the javascript menu you are using. You can actually do that same effect with pure CSS and absolutely positioned content! Just something to think about for users that don't have javascript, or use mobile web.
    "write it for FireFox then hack it for IE."
    Quote Originally Posted by Mhtml View Post
    Domains are like women - all the good ones are taken unless you want one from some foreign country.
    Reputation is your friend

    Development & SEO Tools

  • #3
    Master Coder
    Join Date
    Jun 2003
    Location
    Cottage Grove, Minnesota
    Posts
    9,509
    Thanks
    8
    Thanked 1,090 Times in 1,081 Posts
    I question the Javascript thing too.

    Some people (less than what you think), do have Javascripting disabled.
    So, the argument about using Javascripting ... yada yada

    In any case, you should not use Javascripting (or Flash) for anything that
    is critical to the operation of your site. In your case, navigation is critical.
    So, take ahallicks advice on that one and use CSS instead.

    (also ... www.moosicsmurf.com can't find server)

    Layout looks pretty nice though.
    You basically will give your client what they want, so we can't really judge that.

  • #4
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    Thats not going to work. The images are never displayed to the browser so it won't work. Now you've also made IE go into quirks mode because you have content above the doctype. I think you can easily accomplish the rollover with plain text and background color changing. As to the menu. At least provide pages with the actual content on them so users with JS disabled (like me) can click the links to be taken to the respective pages. You can probably use the <noscript></noscript> tags as well.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #5
    Regular Coder GSimpson's Avatar
    Join Date
    Aug 2006
    Location
    New Zealand
    Posts
    268
    Thanks
    9
    Thanked 0 Times in 0 Posts
    I've got a css preloader that works... I've tested it, now if I fix the javascript thing to css, will it be ok?
    Last edited by GSimpson; 06-01-2007 at 09:20 AM.

  • #6
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    Yes I think so but on a site that small why not just make separate pages? It would be better for seo.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #7
    Regular Coder GSimpson's Avatar
    Join Date
    Aug 2006
    Location
    New Zealand
    Posts
    268
    Thanks
    9
    Thanked 0 Times in 0 Posts
    I find that interactive sites are more fun to stay and look at, and when they're not flash there fun to try and work out. Also i read a few things about websites that people stay too look at, and interactivity is one reason why. Anyways... do you have nay idea how I can go about this css thing cause I'm flat out of ideas.

  • #8
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    As I said before just make alternate pages with the content on them so people with JS disabled are able to click the links and be taken to the respective pages.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #9
    Regular Coder GSimpson's Avatar
    Join Date
    Aug 2006
    Location
    New Zealand
    Posts
    268
    Thanks
    9
    Thanked 0 Times in 0 Posts
    i like the way it is at the moment except for the javascript, so I want to make it css rather than javascript so that I don't need to have seperate pages.

  • #10
    Senior Coder ahallicks's Avatar
    Join Date
    May 2006
    Location
    Lancaster, UK
    Posts
    1,134
    Thanks
    1
    Thanked 57 Times in 55 Posts
    This may help with the CSS menu, instead of the javascript menu.
    "write it for FireFox then hack it for IE."
    Quote Originally Posted by Mhtml View Post
    Domains are like women - all the good ones are taken unless you want one from some foreign country.
    Reputation is your friend

    Development & SEO Tools

  • #11
    Regular Coder GSimpson's Avatar
    Join Date
    Aug 2006
    Location
    New Zealand
    Posts
    268
    Thanks
    9
    Thanked 0 Times in 0 Posts
    I could use that, however, getting to fit right is gonna be a misson cause the menu's on the right. Just before I go a head and do that... Is there a way, other than that, that'l let me use
    a.help:hover { other-div: display none; }
    or something similar, rather than having the p tag inside the anchor.

  • #12
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    If you made the content a span you could do
    Code:
    a.help span {
    display:none;
    }
    a.help:hover span {
    display:block;
    }
    As to my suggestion I don't think you fully understand what I'm saying. I'm saying leave the javascript menu BUT make separate pages for the people with JS disabled. Users with JS enabled get the effect you want and users without it aren't left without seeing content.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #13
    Regular Coder GSimpson's Avatar
    Join Date
    Aug 2006
    Location
    New Zealand
    Posts
    268
    Thanks
    9
    Thanked 0 Times in 0 Posts
    yeah i didn't get what you were saying but now i do. I'm working on the solution now. Just one question though... does php header function work in <noscript> so that if you have noscript then it'll re direct you but if not then let you stay?

  • #14
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    Unfortunately no because noscript has to be in the body tags and php headers have to be before any output to the browser meaning it has to go at the very top of the page. Maybe you can use javascript redirect to the javascript site? This way if JS is enabled they get the menu that uses JS.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #15
    Regular Coder GSimpson's Avatar
    Join Date
    Aug 2006
    Location
    New Zealand
    Posts
    268
    Thanks
    9
    Thanked 0 Times in 0 Posts
    ok... that's a point. Ok, I'm going to do that now. Will get back when I've done it.


  •  
    Page 1 of 2 12 LastLast

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •