Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 9 of 9
  1. #1
    New to the CF scene
    Join Date
    Jul 2007
    Posts
    4
    Thanks
    0
    Thanked 0 Times in 0 Posts

    HTML coding clean up?

    Hi All

    I just changed my style on my website and wanted to know what state it's in really, I'm using Dreamweaver to create the site so I very seldom need to go into the coding side of things, therefore I don't have much knowledge on that side (yet).

    The site from what I can see works ok but would very much like to know and learn about making the coding better, that is if it needs it, which I'm hoping that's where some of you might help.

    Well if your up to assisting the here's my site:

    edit: oops, sorry.
    http://myweb.tiscali.co.uk/terryj/index.htm

    Any suggestions/criticisms (constructive) welcome.

    Cheers.

    .T.J.
    Last edited by .T.J.; 07-23-2007 at 12:41 AM.

  • #2
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    The link you gave goes to a 404 error page, but I can give you this advice, without seeing your site: First, give your page a DOCTYPE (check the sticky at the top of this forum for more on that) Another good step to take would be to validate the site. That will show you any errors in your code.

    HTH
    Dan
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • #3
    New to the CF scene
    Join Date
    Jul 2007
    Posts
    4
    Thanks
    0
    Thanked 0 Times in 0 Posts
    oops, link working now.

    Now validated and DOCTYPE already in place.
    Last edited by .T.J.; 07-23-2007 at 01:03 AM.

  • #4
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    It's pretty nice, all things considered.

    A couple things:

    You use tables for layout, which, while being completely up to you, is frowned upon by modern standards.

    Also, your javascript counter on the first page seems to not work in Firefox.

    HTH
    Dan
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • #5
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    And you also use frames. Do a web search using the works "Why Frames Are Bad?". I also don't like the flame at the top. Its not that good of a quality and it doesn't stop. After a while it gets annoying.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #6
    New to the CF scene
    Join Date
    Jul 2007
    Posts
    4
    Thanks
    0
    Thanked 0 Times in 0 Posts
    I use Firefox also but don't appear to have a problem with the counter, so any tips there would be great.

    The frames came into it because I couldn't figure out a way to be able to have music playing continuous (personal preference here) and not stop or reset itself when you change the page, any thoughts?

    How would I go about having the same setup without tables and frames and have the same results if possible. I like the idea of just the main section of the page being the only bit that changes but to have the same results then I really would need a point in the right direction.

    Thank you for your input so far.

  • #7
    Regular Coder
    Join Date
    Jul 2007
    Posts
    571
    Thanks
    25
    Thanked 28 Times in 28 Posts
    Quote Originally Posted by .T.J. View Post

    How would I go about having the same setup without tables and frames and have the same results if possible.
    Hey T.J.

    Glad to see you interest in making web-sites the proper way, however this is not a simple answer, We can't just tell you "do this and you wont have tables".

    We can tell you why tables are bad, why frames are bad, ect... Weather you deside not to use them is up to you! I say it is up to you because it will require moving away from dreamweavers design view, and start making your entire site by inputting code.

    If your main goal is just to make your personal site then all though your site is not coded properly i would honestly not worry about it. On the other hand if you are serious about building web pages and your goal is to make more then just a personal page I would strongly suggest that you head over to w3schools.com and do there HTML, CSS, and XHTML Tutorials (in that order). Once you are done this invest in a book on CSS, or search the internet for tutorials on making tabless layouts.

    It will be a learning curve and take a while to get going but once u learn it you will be glad you did!
    Last edited by srule_; 07-23-2007 at 03:57 PM.

  • #8
    New to the CF scene
    Join Date
    Jul 2007
    Posts
    4
    Thanks
    0
    Thanked 0 Times in 0 Posts
    That's great, thank you . Link saved and will do some reading, then if I understand it LOL, I will try and put it into practice.

    I'll do some reading on why frames and table are bad though as intrigued why.

    Thinking about how my site works and how easy dreamweaver made it to create, I get a feeling that even with coding knowledge it's not going to be a straight forward task LOL.

    Ok, given that I on my site there are hundreds of photo's, I used photomeister to create the albums (there maybe better software but it was one that was recommended and easy to use) then the main section of my site simply loads up the index file of the particular album/folder and displays it but still shows your places/links you can go to on the left side of the screen (just thinking aloud so to speak).

    I realise that there is a load of information to learn regarding coding, so what would be the general thoughts about where to start re-creating the site to do the same be, eg: coding lessons in a specific area perhaps or an alternate way to work the pages.

    I'm trying to be as clear as I can LOL but it's not so easy to explain when your just starting out and coming away from "I want that there - click - magic, all done"

  • #9
    Regular Coder
    Join Date
    Jul 2007
    Posts
    571
    Thanks
    25
    Thanked 28 Times in 28 Posts
    The first step in recreating your site is making the layout however if you have little HTML & CSS knowladge and skip right to topic specific articles such as creating layouts i doubt you will understand much/get much out of it.

    What i recommend is learning the html and css syntax. once you have an understanding of the basics to building a web page you can then start to learn how to make a layout.


    Like you i was once a dreamweaver disgn view user. The word "code" scared me. Eventually (by ppl like me lol) i was conviced to head over to w3schools.com and learn The coding aspect. To my surprise is was incredibly easy to learn!

    And don't worry if you bought dreamweaver and desided to learn code you did not loose out on your investment! Dreamweaver has amazing features for writting code. It is by far my favorit software when it come to building websites.
    Last edited by srule_; 07-23-2007 at 08:12 PM.


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •